Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix main.ts/preview.ts #14184

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Core: Fix main.ts/preview.ts #14184

merged 1 commit into from
Mar 9, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 9, 2021

Issue: #14095

What I did

Move @babel/register to core-common which is the library that implicitly uses it

self-merging @yannbf

How to test

After publish:

  867  yarn create react-app cra-ts-maints --template typescript
  868  cd cra-ts-main-ts
  869  npx sb@next init
  870  mv .storybook/main.js .storybook/main.ts
  871  yarn storybook

@shilman shilman merged commit 65c8ca7 into next Mar 9, 2021
@shilman shilman deleted the 14095-fix-main-ts branch March 9, 2021 23:48
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant