-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix React unique key warning when using renderLabel #14172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
shilman
changed the title
Fix React unique key warning when using renderLabel
UI: Fix React unique key warning when using renderLabel
Mar 9, 2021
@ghengeveld any thoughts on this diff https://www.chromatic.com/test?appId=5a375b97f4b14f0020b0cda3&id=60468a9c335209002113c1a4 |
This was referenced Mar 11, 2021
Merged
Closed
Closed
Closed
Bump @storybook/addon-actions from 6.2.0-alpha.22 to 6.2.0-beta.14
openlattice/lattice-fabricate#743
Closed
Closed
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14102
What I did
Somehow React thinks the result of invoking
renderLabel
is an array and logs a 'key prop' warning. I suspect this happened because we were calling therenderLabel
function outside of a React tree context, passing the result along in the story data before injecting it elsewhere in a React tree. Needless to say the only way I was able to fix it without affecting the user-facing API was by passing the function itself along in the story data and invoking it where we're rendering it. It might actually be more memory efficient because we're passing the same function reference for each story.How to test
If your answer is yes to any of these, please make sure to include it in your PR.