Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Fix fast refresh socket connection error #14165

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 8, 2021

Issue: #14114

What I did

Updated the ReactFastRefreshPlugin config per experiments with @ndelangen @mrmckeb

self-merging @tooppaaa

How to test

Untested. What we did by hand:

  • Install CRA (4.0+)
  • Install SB
  • See 'ws://localhost:3085/_content/ws' failed: Error during WebSocket handshake: Unexpected response code: 404
  • Patch this fix by hand
  • See error fixed

@shilman shilman requested a review from thomasbertet as a code owner March 8, 2021 10:57
@shilman shilman merged commit d0a93f6 into next Mar 8, 2021
@shilman shilman deleted the 14114-fix-fast-refresh-config branch March 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant