Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sveltedoc-parser to 4.1.0 #14164

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Update sveltedoc-parser to 4.1.0 #14164

merged 1 commit into from
Mar 8, 2021

Conversation

j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Mar 7, 2021

Issue: #14162

What I did

Update sveltedoc-parser to 4.1.0
This version exports now types, I updated the code to use thoses types instead of internals types.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

shilman
shilman approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit bf037ad into storybookjs:next Mar 8, 2021
@shilman shilman mentioned this pull request Mar 8, 2021
Closed
@j3rem1e j3rem1e deleted the upgrade-svelte-docgen branch March 8, 2021 17:18
This was referenced Mar 11, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs dependencies svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j3rem1e @shilman