CLI: Don't allow root directory as static dir #14068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested changes
Feb 26, 2021
|
Applied minor changes @shilman |
shilman
approved these changes
Mar 18, 2021
@shilman I owed you this #14819 (comment) 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13860
Context
When a user builds
storybookinstandalonemode, exists the possibility to provide the root directory (/) as one of the static directories to copy from (probably by mistake). This ends up trying to copy the whole root directory which is an unexpected behavior.What I did
staticDiroption provided contains the root directory:/.staticDirvalue/How to test
Is this testable with Jest or Chromatic screenshots? ✅
Does this need a new example in the kitchen sink apps? I don't think so but since I'm lacking context on what's the scope of the examples I would like the feedback from a maintainer here.
Does this need an update to the documentation? Checking existing
standalone.mdI don't think so but if you think this is an opportunity to add a disclaimer there, this PR can be used for it 😄