-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Support null and undefined in URL args #14049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
Support null and undefined in URL args
[core] Support null and undefined in URL args
Feb 25, 2021
ghengeveld
added
core
maintenance
User-facing maintenance tasks
bug
and removed
maintenance
User-facing maintenance tasks
labels
Feb 25, 2021
coderkevin
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few optional comments on this. In general, it looks good to me! 👍
shilman
changed the title
[core] Support null and undefined in URL args
Core: Support null and undefined in URL args
Feb 26, 2021
This was referenced Mar 7, 2021
This was referenced Mar 12, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -
What I did
This adds support for
null
andundefined
arg values, so that removing an object property or array value in a JSON value will get properly synced to/from the URL.Additionally, this fixes encoding of the space character as
+
rather than%20
.How to test
If your answer is yes to any of these, please make sure to include it in your PR.