Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Args: Prefer react runtime default values #13937

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Args: Prefer react runtime default values #13937

merged 1 commit into from
Feb 17, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 17, 2021 •
edited
Loading

Issue: #12635

Telescoping on #13919

What I did

Start by using the actual default prop as the default arg value. Only try unreliable eval-ing of the table summary if we don't have access to that.

How to test

  • Is this testable with Jest or Chromatic screenshots?

Yep, see affected stories

  • Does this need a new example in the kitchen sink apps?

No

  • Does this need an update to the documentation?

Not sure.

@tmeasday tmeasday requested a review from shilman February 17, 2021 08:44
shilman
shilman approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Prefer react runtime default values Args: Prefer react runtime default values Feb 17, 2021
@shilman shilman merged commit e0d2475 into 12071-consistent-defaultProp-handling Feb 17, 2021
@shilman shilman deleted the 12635-prefer-react-runtime-defaultValues branch February 17, 2021 15:05
@shilman shilman mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: controls addon: docs args bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman