-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix falsey default args handling #13911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday can you take a look at the chromatic changes? probably ok but i'd like a second opinion
@shilman -- I approved the first two changes -- this example was a component with a I'm not sure about the other 8 changes -- are they present on [1] Arguably we shouldn't be setting args to the default value from the component? That might be a discussion for another time. |
@tmeasday I accepted a few more changes (zoom changes are test flake, parameters change is from another PR that slipped in). The remaining ones are all due to this PR I think. |
Issue: #12767
What I did
Check if default value is
undefined
, rather than falsey before excluding it.How to test
Yes, see test
I think probably not. I don't think these things are picked up by chromatic anyway so don't end up being very useful to have edge cases, unless they are hard to reproduce.