Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Select search input value on / #13884

Merged
merged 1 commit into from
Feb 16, 2021
Merged

UI: Select search input value on / #13884

merged 1 commit into from
Feb 16, 2021

Conversation

ghengeveld
Copy link
Member

Issue: -

What I did

Besides setting focus to the search input, this also selects the input value so it can easily be replaced with a new query on subsequent searches.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shilman shilman changed the title Select search input value on / UI: Select search input value on / Feb 16, 2021
@shilman shilman merged commit 8c3d215 into next Feb 16, 2021
@shilman shilman deleted the select-search-input branch February 16, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants