CLI: Don't try to add packages that are already installed #13876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
added
maintenance
gaetanmaisse
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
phated
reviewed
Feb 11, 2021
merceyz
reviewed
Feb 12, 2021
It mimic the behavior of Yarn 1.x when trying to install a package as dev dep but it is already a regular dep. Example: > warning "react-scripts" is already in "dependencies". Please remove existing entry first before adding it to "devDependencies". > success Saved 0 new dependencies.
gaetanmaisse
force-pushed
the
tech/improve-cli
branch
from
9956194 to
b035493
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #13559 step by step to not face gigantic conflicts or issues with the webpack 4/5 works.
What I did
Previously for some framework, the Storybook CLI was installing extra dependencies (listed in the generator of each framework, for instance for rax) but, in some case, some were already present in the user's project.
It doesn't cause any issue with NPM/Yarn, I guess they are just updating the version 🤷🏻 . But, reasonably from my point of view, Yarn 2 is throwing an error:
To fix that I added a filter before adding the extra dependencies to remove all the already installed ones.
How to test