Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global hook for Vue Devtools #1376

Merged
merged 4 commits into from
Jul 23, 2017
Merged

Update global hook for Vue Devtools #1376

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c25ac5b
Update global hook for Vue Devtools
matt-oconnell Jun 20, 2017
e50d7b2
Merge branch 'release/3.2' into update-global-hook
ndelangen Jul 6, 2017
45ada35
Merge branch 'release/3.2' into update-global-hook
ndelangen Jul 18, 2017
ecd054d
Merge branch 'release/3.2' into update-global-hook
ndelangen Jul 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/vue/src/server/iframe.html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export default function({ assets, publicPath, headHtml }) {
<meta name="viewport" content="width=device-width, initial-scale=1">
<script>
if (window.parent !== window) {
window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = window.parent.__REACT_DEVTOOLS_GLOBAL_HOOK__;
window.__VUE_DEVTOOLS_GLOBAL_HOOK__ = window.parent.__VUE_DEVTOOLS_GLOBAL_HOOK__;
window.parent.__VUE_DEVTOOLS_CONTEXT__ = window.document;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-oconnell I don't know how storybook works, why do we need this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't unless we want to ensure Devtools looks directly at this context. It would possibly speed up start up time a bit. I can remove it if you want me to

Copy link

@posva posva Jul 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it looks fine like this 🙂

Thanks for the follow up!

}
</script>
<title>Storybook</title>
Expand Down