Dependencies: Update postcss-loader to ^4.1.0 #13640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the code to support the changes to options block, and adds an explicit postcss dependency at ^7.0.35 since it is now a peerDep of postcss-loader
|
cc'ing @ThibaudAV since I updated the loader in the angular stuff, too. |
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Ref #12668
What I did
I dug into the PostCSS stuff related to the v8 upgrades, specifically what happened in the breaking change to
postcss-loader. It looks like the primary changes were dropping support for node <10.13, changing the way config options were specified and making PostCSS a peerDepedency.Since the embedded
postcss-loaderin Storybook has control of all those things, it seems that this can be updated (in a non-breaking manner) to ^4.1.0 as long as a PostCSS@^7 is added as a direct dependency of@storybook/core.I believe upgrading this loader is the first step in moving us towards supporting PostCSS v8.
How to test
examples/html-kitchen-sink.examples/html-kitchen-sink.If your answer is yes to any of these, please make sure to include it in your PR.