Addon-actions: Normalize args #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addon-action now will now show results out of an array when its not an array.
shilman
changed the title
gaetanmaisse
approved these changes
Jan 14, 2021
|
LGTM 💪🏻 , I will let @shilman make a double-check. |
shilman
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7764
addon-action now will show results out of an array when it's not an array.
What I did
I added treatment for the args received on addon-actions. Before, it was sending the args forward. Now, when it is only one argument, it will send the argument outside of an array.
Before:
After:
How to test
I did update the tests
No
I don't think so.
If your answer is yes to any of these, please make sure to include it in your PR.
Thanks @yannbf for the guidance :D