-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Add CSF types #13519
HTML: Add CSF types #13519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbf looking great! 💯
one thing: can you add this to the exiting html-kitchen-sink
instead of creating a new example? every example we create adds overhead to the build etc.
You mean convert the entire project to typescript? I can do that |
@yannbf do we need to convert anything? TS is built into storybook, so i'd expect random bits of typescript to work in the existing project without needing to update anything else. or am i missing something? |
If anyone wants to copy the entire html kitchen sink folder they wouldn't be able to run it if it was mixed like that I believe, but I'm also not sure how likely people would do that Edit: updated! |
a565ad2
to
cd5905f
Compare
@shilman there seems to be changes in chromatic, but I don't think it's related to this PR 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
What I did
This PR does the following:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.