Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Add CSF types #13519

Merged
merged 5 commits into from
Jan 2, 2021
Merged

HTML: Add CSF types #13519

merged 5 commits into from
Jan 2, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 26, 2020

What I did

This PR does the following:

  1. Add 6.0 types to @storybook/html
  2. Add HTML typescript CLI templates
  3. A kitchen sink project in the examples folder for HTML typescript

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? Added!
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf looking great! 💯

one thing: can you add this to the exiting html-kitchen-sink instead of creating a new example? every example we create adds overhead to the build etc.

@yannbf
Copy link
Member Author

yannbf commented Dec 29, 2020

@yannbf looking great! 💯

one thing: can you add this to the exiting html-kitchen-sink instead of creating a new example? every example we create adds overhead to the build etc.

You mean convert the entire project to typescript? I can do that

@shilman
Copy link
Member

shilman commented Dec 29, 2020

@yannbf do we need to convert anything? TS is built into storybook, so i'd expect random bits of typescript to work in the existing project without needing to update anything else. or am i missing something?

@yannbf
Copy link
Member Author

yannbf commented Jan 2, 2021

@yannbf do we need to convert anything? TS is built into storybook, so i'd expect random bits of typescript to work in the existing project without needing to update anything else. or am i missing something?

If anyone wants to copy the entire html kitchen sink folder they wouldn't be able to run it if it was mixed like that I believe, but I'm also not sure how likely people would do that

Edit: updated!

@yannbf yannbf force-pushed the feature/html-ts-template-and-types branch from a565ad2 to cd5905f Compare January 2, 2021 08:57
@yannbf
Copy link
Member Author

yannbf commented Jan 2, 2021

@shilman there seems to be changes in chromatic, but I don't think it's related to this PR 🤔

@shilman shilman changed the title HTML: add CSF types HTML: Add CSF types Jan 2, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shilman shilman merged commit 9b90b97 into next Jan 2, 2021
@shilman shilman deleted the feature/html-ts-template-and-types branch January 2, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants