Rax: Migrate to TS #13450
Merged
Rax: Migrate to TS #13450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
added
maintenance
gaetanmaisse
commented
Dec 14, 2020
|
E2E tests are working for Rax, see https://app.circleci.com/pipelines/github/storybookjs/storybook/15779/workflows/b7eb45a2-abcb-40c6-8715-4315faa69563/jobs/286907/parallel-runs/1?filterBy=ALL -- Only preact ones are KO, preactjs/preact-cli#1493 in progress. |
gaetanmaisse
force-pushed
the
tech/migrate-rax-to-ts
branch
2 times, most recently
from
54b9ed7 to
82d7de6
Compare
gaetanmaisse
force-pushed
the
tech/migrate-rax-to-ts
branch
from
82d7de6 to
a13af7b
Compare
ThibaudAV
approved these changes
Jan 9, 2021
gaetanmaisse
force-pushed
the
tech/migrate-rax-to-ts
branch
from
a13af7b to
e998038
Compare
Signed-off-by: Gaëtan Maisse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: This is the last stone of #5030 😱 🥳 🎉
(I would love to merge this PR and close #5030 myself as it was the issue of my first contribution to SB 😍 )
What I did
Fastly migrate
@storybook/raxto TS as I want to close the big TS Migration Issue before moving to improve types of@storybook/core.How to test