Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot: migrate to TS #13447

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Riot: migrate to TS #13447

merged 1 commit into from
Jan 13, 2021

Conversation

gaetanmaisse
Copy link
Member

Issue: Part of #5030

What I did

Fastly migrate @storybook/riot to TS as I want to close the big TS Migration Issue before moving to improve types of @storybook/core.

How to test

  • CI should be 🟢 , we rely only on examples as there is no E2E for Riot (it looks like there are some issues with Riot 4 + SB 🤷🏻 )

@gaetanmaisse gaetanmaisse added app: riot maintenance User-facing maintenance tasks labels Dec 14, 2020
@gaetanmaisse gaetanmaisse force-pushed the tech/migrate-riot-to-ts branch from 64bcafa to c30d064 Compare December 14, 2020 20:15
@gaetanmaisse gaetanmaisse mentioned this pull request Dec 14, 2020
Closed
@gaetanmaisse gaetanmaisse marked this pull request as ready for review December 14, 2020 20:55
@gaetanmaisse gaetanmaisse requested a review from a team December 14, 2020 20:55
@gaetanmaisse gaetanmaisse force-pushed the tech/migrate-riot-to-ts branch from c30d064 to d49c261 Compare December 16, 2020 10:50
@gaetanmaisse gaetanmaisse force-pushed the tech/migrate-riot-to-ts branch from d49c261 to 13c190b Compare January 8, 2021 16:50
@gaetanmaisse gaetanmaisse requested a review from ThibaudAV January 8, 2021 16:50
ThibaudAV
ThibaudAV approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@ThibaudAV ThibaudAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/riot/src/client/preview/render-riot.test.ts Outdated Show resolved Hide resolved
@gaetanmaisse gaetanmaisse force-pushed the tech/migrate-riot-to-ts branch 2 times, most recently from 6fa6ab3 to 1b37089 Compare January 10, 2021 09:16
@gaetanmaisse gaetanmaisse force-pushed the tech/migrate-riot-to-ts branch from 1b37089 to 8fe8345 Compare January 13, 2021 19:05
@gaetanmaisse gaetanmaisse merged commit a3e4426 into next Jan 13, 2021
@gaetanmaisse gaetanmaisse deleted the tech/migrate-riot-to-ts branch January 13, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaudAV ThibaudAV ThibaudAV approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @ThibaudAV