-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove package lock #1338
Remove package lock #1338
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 9.43% 13.76% +4.32%
==========================================
Files 204 202 -2
Lines 4630 4621 -9
Branches 518 588 +70
==========================================
+ Hits 437 636 +199
+ Misses 3716 3464 -252
- Partials 477 521 +44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕶
Issue: N/A
What I did
Travis builds like this one (#1337) are failing mysteriously all of a sudden. The only recent change that could be related (AFAIK) is my addition of npm5's
package-lock.json
to the repo.This change removes all
package-lock.json
files, and also adds them to gitignore for now.How to test
socket.upgradeReq
, so usereq
instead #1337 to see if it fixes the problem. (Update: it does!)