remove the cli tests #13318
Closed
remove the cli tests #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
danielduan,
shilman and
stijnkoopal
as code owners
|
Isn't it a better idea to not remove the entire test suite, but only the test fixtures? #12936 aims at leveraging Jest for the purpose; we can keep the test case for default behavior. |
|
The fixtures ARE the only tests AFAIK? |
#12936 introduces a test case that makes sure that the closest match shows up on supplying an unknown command. |
|
@jamesgeorge007 ah that seems really valuable, I like that. If this is merged, can you adjust your PR to add any requirements back for the above? |
I think a better idea would be to address this as part of #12936 if you're okay with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the cli tests
why?
These test were setup before we had the examples-v2 tests
The removed test tested whether the storybook CLI & resulting bootstrapped storybook works.
However these fixtures do not get updated, and so over time have come to reflect what user experience less and less.
Now that we have tests that run against the latest (and other versions) of things like CRA & angular-cli I think it's safe to remove these tests.