Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Don't install babel for CRA #13220

Merged
merged 1 commit into from
Nov 23, 2020
Merged

CLI: Don't install babel for CRA #13220

merged 1 commit into from
Nov 23, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Nov 23, 2020 •
edited by shilman
Loading

Issue: #4764

What I did

  • Skip babel dependencies for CRA

How to test

  • CI

@tooppaaa tooppaaa added maintenance User-facing maintenance tasks cli labels Nov 23, 2020
@shilman shilman changed the title CLI: do not install babel for CRA CLI: Do not install babel for CRA Nov 23, 2020
@shilman shilman added bug cra Prioritize create-react-app compatibility and removed maintenance User-facing maintenance tasks labels Nov 23, 2020
@shilman shilman added this to the 6.1 essentials milestone Nov 23, 2020
@shilman shilman changed the title CLI: Do not install babel for CRA CLI: Don't install babel-loader for CRA Nov 23, 2020
@shilman shilman changed the title CLI: Don't install babel-loader for CRA CLI: Don't install babel for CRA Nov 23, 2020
@shilman shilman merged commit 3df76ec into next Nov 23, 2020
@shilman shilman deleted the fix/skipBabelForCRA branch November 23, 2020 13:30
@shilman shilman mentioned this pull request Nov 23, 2020
Closed
@shilman shilman mentioned this pull request Jan 11, 2021
Closed
@gaetanmaisse gaetanmaisse mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
bug cli cra Prioritize create-react-app compatibility
Projects
None yet
Milestone
6.1 essentials
Development

Successfully merging this pull request may close these issues.
2 participants
@tooppaaa @shilman