Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-viewport: Add viewports of the latest iPhones #13176

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Addon-viewport: Add viewports of the latest iPhones #13176

merged 3 commits into from
Jan 14, 2021

Conversation

YutaSugimura
Copy link
Contributor

The addition of new devices

What was done:

  • Added iPhone12, iPhone12 mini, iPhone12 Pro Max, iPhone SE2.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @YutaSugimura. thanks for your contribution!!

@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
Copy link
Member

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YutaSugimura I just added a mini-comment for a typo, can you take in into account and ping me so that I merge the PR?

addons/viewport/src/defaults.ts Outdated Show resolved Hide resolved
@stale stale bot removed the inactive label Jan 13, 2021
@gaetanmaisse gaetanmaisse changed the title Add new Devices Addon-viewport: Add viewports of the latest iPhones Jan 14, 2021
@gaetanmaisse gaetanmaisse merged commit 210d344 into storybookjs:next Jan 14, 2021
@gaetanmaisse
Copy link
Member

Thanks for your contribution @YutaSugimura!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants