Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Reduce rerenders when changing the selected story #13107

Merged
merged 12 commits into from
Nov 16, 2020
Merged

UI: Reduce rerenders when changing the selected story #13107

merged 12 commits into from
Nov 16, 2020

Conversation

ghengeveld
Copy link
Member

What I did

This optimizes various things related to rerendering whenever the selected story changes.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld changed the title Tree selection performance UI: Tree selection performance Nov 13, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2020 •
edited
Loading

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against ec07da9

@ghengeveld ghengeveld changed the title UI: Tree selection performance UI: Tree story selection performance Nov 13, 2020
@ghengeveld ghengeveld changed the title UI: Tree story selection performance UI: Performance enhancements for changing the selected story Nov 13, 2020
@ghengeveld ghengeveld changed the title UI: Performance enhancements for changing the selected story UI: Reduce rerenders and other work when changing the selected story Nov 13, 2020
@ghengeveld ghengeveld requested a review from shilman November 13, 2020 20:43
@shilman
Copy link
Member

shilman commented Nov 14, 2020

@ghengeveld can you look into why the benchmark is breaking with these changes?

@ghengeveld ghengeveld changed the title UI: Reduce rerenders and other work when changing the selected story UI: Reduce rerenders when changing the selected story Nov 16, 2020
@ghengeveld ghengeveld added the maintenance User-facing maintenance tasks label Nov 16, 2020
shilman
shilman approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 6775282 into next Nov 16, 2020
@shilman shilman deleted the tree-selection-performance branch November 16, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@shilman shilman

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks performance issue ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @shilman @ndelangen