-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Make sure cache is available before trying to use it #13012
Conversation
Good call @ho1234c! What's up with the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I left some remarks.
I see. optional chaining is best..! |
1d524b6
to
ab1e9eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing and pulling it through!
I encountered error as below. so I could not start story book dev server. I try remove and install node_moudles many time but still broken.
What I did
I think file system cache is fragile. in my case, don't know why, but the cache is broken.
so I add logic to prevent non-execution in the event of cache problem.
It is nit change but since I spent a lot of time to find solution, I hope it helps someone.
and I modified eslint rule to pass commit lint.