Core: Add STORYBOOK environment variable #12997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmeasday WDYT? seems reasonable but I'm a little unclear on the use case |
|
Sure, seems reasonable to me |
shilman
changed the title
|
Aha @toshi1127 this got converted to TS recently. Any chance you can redo the PR in the new files? |
…feature/add-default-environment-variable
|
@shilman |
shilman
reviewed
Nov 4, 2020
shilman
approved these changes
Nov 4, 2020
|
Did this feature disappear? I need to change some postcss config for Storybook only, but in postcss.config.js |
|
Yeah, I'm also not seeing this anymore @shilman. Version 6.4.7 |
|
I found the current source version 6.5.9 https://github.com/storybookjs/storybook/blob/next/lib/core-common/src/utils/envs.ts#L15 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12416
What I did
By Default, the environment variable
STORYBOOKis set totrue.How to test
Is this testable with Jest or Chromatic screenshots?
yes.
I have tested that
process.env.STORYBOOKis set to true.Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
Should I update this document?