Chore: update documentation to address issue #10856 #12777
Conversation
jonniebigodes
added
documentation
patch:yes
| The `children` `args` as any other arg needs to be JSON serializable. This means that you should: | ||
|
|
||
| - avoid using empty values. | ||
| - avoid using components that include third party libraries such as `emotion`. |
There was a problem hiding this comment.
not sure we know enough to put this in the docs. i think emotion does work in general, but fails in some cases--not sure which ones yet.
There was a problem hiding this comment.
@shilman as you said it we don't know much about it yet, and it will be a bit of "pickle" (pardon the bad pun) to hunt down each and every use case, for now we could probably frame it as :
The `children` `args` as any other arg needs to be JSON serializable. This means that you should:
- avoid using empty values
- use caution with components that include third party librariesLet me know if you're ok with the changes and i'll commit them and we get it in the docs
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
shilman
added
the
patch:done
Chore: update documentation to address issue #10856
With this pull request the issue #10856 is addressed and can be closed.
What was done:
workflows/stories-for-multiple-componentspage to address the issue at hand.writing-stories/argsto include a bit more context to match the page above.Feel free to provide feedback