Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Improve angular e2e tests #12723

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Build: Improve angular e2e tests #12723

merged 2 commits into from
Oct 10, 2020

Conversation

gaetanmaisse
Copy link
Member

What I did

  • Use yarn instead of npx to bootstrap angular e2e tests
  • Display yarn install/add command output when running the E2E tests

How to test

  • CI should be 🟢 except Angular tests that are currently failing
  • We should be able to see the cause of the issue in Angular tests:

error @aduh95/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.17.0 || >=13.2.0". Got "12.16.2"
error Found incompatible module.

@gaetanmaisse
ci: use yarn instead of npx to bootstrap angular e2e tests
df39df3 
Use npx causes a mix of both `package-lock.json` and `yarn.lock`.
Plus, we download `@angular/cli` dep with yarn so it looks normal to use it.
@gaetanmaisse
ci: display yarn install/add command output when running the E2E tests
5b992ae 
It helps a lot during investigation of some dependency issues and avoid to have to use SSH to debug things.
@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Oct 10, 2020
@gaetanmaisse gaetanmaisse marked this pull request as ready for review October 10, 2020 08:08
shilman
shilman approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good catch!

shilman
shilman approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good catch!

@shilman shilman changed the title Test: Improve angular e2e tests Build: Improve angular e2e tests Oct 10, 2020
@shilman shilman merged commit 832fe1b into next Oct 10, 2020
@shilman shilman deleted the tech/improve-angular-e2e-tests branch October 10, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tooppaaa tooppaaa Awaiting requested review from tooppaaa

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @shilman