-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update old namespace link and incorrect UI link #1271
Conversation
I noticed the npm link command is out of date in the contribution guide and updated it to what I believe it should be, as well as a link to the Storybook UI page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
@orta Travis build is failing due to
Have you ever seen this, and do you have a workaround? |
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 13.73% 13.73%
=======================================
Files 207 207
Lines 4638 4638
Branches 519 574 +55
=======================================
Hits 637 637
+ Misses 3552 3510 -42
- Partials 449 491 +42
Continue to review full report at Codecov.
|
Issue:
I noticed the npm link command is out of date in the contribution guide and updated it to what I believe it should be, as well as a link to the Storybook UI page.
What I did
Went through the process of linking the storybook source code locally based on the contribution guide and fixed the out of date docs
How to test