ADD async render support #1253
Closed
ADD async render support #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
========================================
Coverage 14.35% 14.35%
========================================
Files 201 201
Lines 4612 4612
Branches 499 614 +115
========================================
Hits 662 662
+ Misses 3522 3426 -96
- Partials 428 524 +96
Continue to review full report at Codecov.
|
ndelangen
force-pushed
the
async-render-support
branch
from
4357ee3 to
f747828
Compare
shilman
requested changes
Jun 12, 2017
danielduan
approved these changes
Jul 1, 2017
danielduan
reviewed
Jul 1, 2017
| const error = { | ||
| title: `Expecting a React element from the story: "${selectedStory}" of "${selectedKind}".`, | ||
| description: stripIndents` | ||
| return Promise.resolve(story(context)).then(element => { |
There was a problem hiding this comment.
I think it'd be nice to have an example usage of this somewhere.
There was a problem hiding this comment.
Good point!, thanks for the review 👍
|
I'm dropping this for now, and will revisit this at a later stage. |
|
Please do NOT remove remote branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -add is sync but sometimes we want to do some async setup on first render-
What I did
Add support for a function in
.add()that returns a PromiseTodo
How to test
Should add something to the kitchen sink probably.