-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Fix storiesof-to-csf codemod for TypeScript #12453
CLI: Fix storiesof-to-csf codemod for TypeScript #12453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @remorses, thanks so much for fixing this! 😍
The change seems to be messing up the snapshot tests. I dug in for a minute but wasn't obvious to me why... do you have any ideas?
Seems like all changes are just quotes.. Is there some prettier config we need to pass in? |
I put some logging in earlier and the project prettier config which is supposed to be respected (awesome!) seems to have single quotes, but the output has double quotes. |
Fixed, now it is using the correct prettier config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
CLI: Fix storiesof-to-csf codemod for TypeScript
Issue: #9669
What I did
StringLiteral
ast name instead ofLiteral
when using typescript