Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storyshots: Remove needless iteration testStorySnapshots #12321

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Storyshots: Remove needless iteration testStorySnapshots #12321

merged 1 commit into from
Aug 31, 2020

Conversation

Connormiha
Copy link
Contributor

Issue:

What I did

I just optimized for loop avoiding needless collection iteration.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    Yes
  • Does this need a new example in the kitchen sink apps?
    No
  • Does this need an update to the documentation?
    No

shilman
shilman approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@shilman shilman added this to the 6.1 maintenance milestone Aug 31, 2020
@shilman shilman changed the title Remove needless iteration testStorySnapshots Storyshots: Remove needless iteration testStorySnapshots Aug 31, 2020
@shilman shilman merged commit a4b6a69 into storybookjs:next Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
addon: storyshots maintenance User-facing maintenance tasks performance issue
Projects
None yet
Milestone
6.1 maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@Connormiha @shilman