-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small design update to addon info package #1213
Add small design update to addon info package #1213
Conversation
When using the "info" addon inline, the current designs blends in too much with the component, making it quite confusing and sometimes difficult to preview. This change wraps the Story info into a "box" with a light border and shadow, also adds some more padding and margin to give a bit more room.
We've been discussing the info addon quite a bit lately, and most of us agree it's contents should not be in the preview at all. We should move it into a panel. What's your take on this? |
@ndelangen after submitting this PR I've found those discussions about moving the info addon to its own panel, and it makes much more sense. If it's something that's near from happening, then I wouldn't even bother merging it. |
This is super easy to merge now and release as Moving the contents into a panel will not be part of I'd really like everyone's input on wether we can just simply move the content of addon-info into a panel and what strategy we should have:
Obviously (1) is preferable in the long game, for us the maintainers. But what do users want? |
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
=======================================
Coverage 13.72% 13.72%
=======================================
Files 207 207
Lines 4640 4640
Branches 527 511 -16
=======================================
Hits 637 637
- Misses 3533 3564 +31
+ Partials 470 439 -31
Continue to review full report at Codecov.
|
@ndelangen @lucasmotta full discussion of the panel proposal is here: #1147 |
Issue:
When using the "info" addon inline, the current designs blends in too much with the component, making it quite confusing and sometimes difficult to preview.
What I did
This change wraps the Story info into a "box" with a light border and shadow, also adds some more padding and margin to give a bit more room.