Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix source code for Template.bind({}) in MDX #12107

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Addon-docs: Fix source code for Template.bind({}) in MDX #12107

merged 1 commit into from
Aug 18, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 18, 2020 •
edited
Loading

Issue: #12054

What I did

Follow .bind() calls back to their declarations

How to test

See updated snapshots, and args stories in examples

@shilman
Copy link
Member Author

shilman commented Aug 18, 2020

self-merging @tmeasday, including the comment fix from the previous PR

@shilman shilman added this to the 6.0.x milestone Aug 18, 2020
@shilman shilman merged commit 8ba6c97 into next Aug 18, 2020
@shilman shilman mentioned this pull request Aug 19, 2020
Closed
jimmyandrade
jimmyandrade reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stof stof deleted the 12054-fix-mdx-source-for-template branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyandrade jimmyandrade jimmyandrade left review comments

Assignees
No one assigned
Labels
addon: docs block: source bug mdx
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @jimmyandrade