Core: Add frameworkPath to options to support custom frameworks #12087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition allows an override of the hardcoded
`@storybook/${framework}` import path in the (generated) preview code.
re #12075
ThaNarie
requested review from
alterx,
igor-dv,
ndelangen,
shilman and
tmeasday
as code owners
shilman
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
This looks awesome @ThaNarie !
Are you OK if we release this in a 6.1-alpha next week?
@ndelangen @tmeasday Do you think we can call this a bug and patch it to 6.0? I think it was an accident that we don't allow non-storybook framework packages.
tmeasday
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12075
What I did
This addition allows an override of the hardcoded
@storybook/${framework}import path in the (generated) preview code.I tested these changes first in a separate project that would need this feature to work, by changing the node_modules.
I'm not sure if any of the automated tests cover the creation of custom frameworks, or running normal framework webpack builds at all, so I haven't run or included any tests.
How to test
If your answer is yes to any of these, please make sure to include it in your PR. - Done