Composition: Verify refs in node #12085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f it's reachable from node
… client-side && show error if no stories & server-check
tmeasday
reviewed
Aug 18, 2020
|
Ready for review @rannyeli @TechieQian @basher @tmeasday |
Co-authored-by: Tom Coleman <[email protected]>
…bookjs/storybook into tech/refs-verify-existence-in-node # Conflicts: # lib/api/src/modules/refs.ts
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11892
What I did
iframe.htmliframe.htmlinlib/api/modules/refslib/api/modules/refsto use the set type of a ref as a replacement for runtime checkingiframe.htmllib/api/modules/refsto not requeststories.jsonwith credentials when the server-side fetch succeeded, because that means it's public.