Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-controls: Fix argType inference priority #12048

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Addon-controls: Fix argType inference priority #12048

merged 2 commits into from
Aug 15, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 15, 2020 •
edited
Loading

Issue: #12007

What I did

Fix the priority of argTypes enhancers: user specified argTypes > docgen-extracted > args data-inferred

Self-merging @tmeasday

How to test

See repro from issue added to cra-ts-essentials

@shilman shilman added this to the 6.0.x milestone Aug 15, 2020
@shilman shilman merged commit 4886eef into next Aug 15, 2020
@shilman shilman mentioned this pull request Aug 15, 2020
Closed
tmeasday
tmeasday reviewed Aug 16, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I'd sort of like to see an explicit unit test for it in the story store.

@tknickman tknickman mentioned this pull request Aug 19, 2020
Closed
@shilman shilman mentioned this pull request Aug 25, 2020
Merged
@stof stof deleted the 12007-fix-arg-type-precedence branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday left review comments

Assignees
No one assigned
Labels
addon: controls addon: docs bug
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday