Addon-A11y: Fix manual run & timeline #12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooppaaa
requested review from
CodeByAlex,
jbovenschen and
usulpro
as code owners
tooppaaa
commented
Aug 13, 2020
| const { manual } = useParameter<Pick<A11yParameters, 'manual'>>('a11y', { | ||
| manual: false, | ||
| }); | ||
| const [status, setStatus] = useState<Status>(manual ? 'manual' : 'initial'); |
There was a problem hiding this comment.
Using useAddonState on this didn't worked
- useEffect doesn't update 'right' addon state
- adding it to dependencies of useEffect overflows
tooppaaa
force-pushed
the
fix/a11yManualRun
branch
from
2b43ce5 to
ec047c2
Compare
|
cc @tmeasday |
tmeasday
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
LGTM although I don't really know this code well. Should @ndelangen take a look?
ndelangen
approved these changes
Aug 18, 2020
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11802
What I did
How to test