Bump react-syntax-highlighter to 13.2.1 #11838
Conversation
|
it would be great to finish this, merge it and release it. |
|
+1 for backporting this fix to the 5.x version. Would love to keep dependencies up to date with Storybook! |
|
Looks like several CI tasks are failing, would you mind update to latest next branch? Also react-syntax-highlighter has release a few more times up to 13.4.0. |
|
Please could you also update it in https://github.com/storybookjs/storybook/blob/next/addons/storysource/package.json#L45 |
…dateReactSyntaxHighlighter
|
@fernandopasik thanks for the comment! |
There was a problem hiding this comment.
Looks like there are definitely some breaking changes to deal with before we can merge. @Naturalclar are you able to access the Chromatic diffs linked below? cc @ndelangen
|
Seems the syntax parsing works great, the theme changed a bit, but we can fix that. I did some quick checks. |
|
Sorry guys I didn't noticed this. Yes, there's definitely a theme change. |
|
@fernandopasik would you want to fix this today? We could do it together if you'd like? |
|
Yes, I'll help on this tomorrow. |
|
@Naturalclar want to pair program with us tomorrow? |
|
@ndelangen I'd be happy to join on the pair programming if I'm available :) |
|
17:30 UTC 20th of August (today) 2020 |
|
@Naturalclar we went through the code and seems like there's a new option in react-syntax-highlighter that would make at least the biggest issue away https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases/tag/13.0.0 I hope you don't mind I pushed the change to the branch. I'm looking at the color issues, seems like the theme got messed by some css classes duplicated from the update somehow. |
|
@ndelangen @fernandopasik |
|
@Naturalclar happy to chat directly on discord and find a better time-slot for you, I didn't notice your timezone 🙈 |
|
@ndelangen I've narrowed down the issues down to 2, I've tried a few things but didn't make it better. |
|
💯 x 💯 👏 |
|
@shilman could this one be merged? |
|
It will 💯!! @shilman wants the ensure 6.0.x is stable first, before merging in 6.x.x changes. |
shilman
changed the title
|
It breaks Storybook for IE 11 #12399 |
Dependabot failing to generate automated security update again. If this doesn't resolve, manually dismiss again and follow-up with https://github.com/upleveled/yarn-security-fixes#techniques-to-fix-transitive-dependencies. https://github.com/leotm/react-native-template-typescript/security/dependabot/yarn.lock/prismjs/closed Note - storybookjs/storybook#11890 - storybookjs/storybook#11838 - react-syntax-highlighter/react-syntax-highlighter#415 - react-syntax-highlighter/react-syntax-highlighter#414
Issue: #11890
there was new security alert for prismjs, which react-syntax-highlighter was using.
What I did
bumped react-syntax-highlighter to 13.2.1 to address security alert for prismjs.
it's a change in major version, but the only breaking change is
draculatheme being changed todarculahttps://github.com/react-syntax-highlighter/react-syntax-highlighter/releases
How to test
If your answer is yes to any of these, please make sure to include it in your PR.
n/a