Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist CSF .story annotations #11617

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Hoist CSF .story annotations #11617

merged 2 commits into from
Jul 20, 2020

Conversation

tmeasday
Copy link
Member

Issue: Warnings about .story =

What I did

Got rid of it

@tmeasday tmeasday requested a review from shilman July 20, 2020 04:21
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 244ae06

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Jul 20, 2020
shilman
shilman approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Remove stories annotation Hoist CSF .story annotations Jul 20, 2020
@shilman shilman added this to the 6.0 milestone Jul 20, 2020
@shilman shilman merged commit 670abd4 into next Jul 20, 2020
@stof stof deleted the remove-stories-annotation branch May 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman