Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition: Fix docs-only story handling for composed storybooks #11537

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

ndelangen
Copy link
Member

Issue: #11302

What I did

  • move code responsible for restructuring docs-only stories to the rendering section, so refs get this behavior as well.

How to test

  • test should pass
  • on the official example go to: /?path=/story/@storybook/design-system_design-system-avatar--basic

…ering section, so refs get this behavior as well.
@ndelangen ndelangen self-assigned this Jul 14, 2020
@ndelangen ndelangen added this to the 6.0 composition milestone Jul 14, 2020
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title FIX incorrect tree when docs-only is used in composed storybook Composition: Fix docs-only story handling for composed storybooks Jul 15, 2020
@shilman shilman merged commit 764328b into next Jul 15, 2020
@ndelangen ndelangen deleted the fix/rendering-docs-only-refd-stories branch July 15, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants