Added an upgrade mode to getstorybook #1146
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| const helpers = require('../../lib/helpers'); | ||
| const latestVersion = require('latest-version'); | ||
| const spawn = require('child-process-promise').spawn; | ||
| const path = require('path'); | ||
|
|
||
| const packageNames = require('@storybook/codemod').packageNames; | ||
|
|
||
| function updatePackage(devDependencies, oldName, newName) { | ||
| if (devDependencies[oldName]) { | ||
| return latestVersion(newName).then(version => { | ||
| delete devDependencies[oldName]; | ||
| devDependencies[newName] = version; | ||
| }); | ||
| } else { | ||
| return Promise.resolve(null); | ||
| } | ||
| } | ||
|
|
||
| function updatePackageJson() { | ||
| const packageJson = helpers.getPackageJson(); | ||
| const { devDependencies } = packageJson; | ||
|
|
||
| return Promise.all( | ||
| Object.keys(packageNames).map(oldName => { | ||
| const newName = packageNames[oldName]; | ||
| return updatePackage(devDependencies, oldName, newName); | ||
| }) | ||
| ).then(() => { | ||
| if (!devDependencies['@storybook/react'] && !devDependencies['@storybook/react-native']) { | ||
| throw new Error('Expected to find `@kadira/[react-native]-storybook` in devDependencies'); | ||
| } | ||
| helpers.writePackageJson(packageJson); | ||
| }); | ||
| } | ||
|
|
||
| function updateSourceCode() { | ||
| const jscodeshiftPath = path.dirname(require.resolve('jscodeshift')); | ||
| const jscodeshiftCommand = path.join(jscodeshiftPath, 'bin', 'jscodeshift.sh'); | ||
|
|
||
| const codemodPath = path.join( | ||
| path.dirname(require.resolve('@storybook/codemod')), | ||
| 'transforms', | ||
| 'update-organisation-name.js' | ||
| ); | ||
|
|
||
| const args = ['-t', codemodPath, '--silent', '--ignore-pattern', '"node_modules|dist"', '.']; | ||
|
|
||
| return spawn(jscodeshiftCommand, args, { stdio: 'inherit' }); | ||
| } | ||
|
|
||
| module.exports = updatePackageJson().then(updateSourceCode); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,12 +7,12 @@ | |
| "type": "git", | ||
| "url": "git+https://github.com/storybooks/storybook.git" | ||
| }, | ||
| "main": "dist/index.js", | ||
|
There was a problem hiding this comment. I'm not sure if the old There was a problem hiding this comment. This package is never ever required by anything. This explains why this bug was never found. |
||
| "dependencies": { | ||
| "jscodeshift": "^0.3.30" | ||
| }, | ||
| "scripts": { | ||
| "prepublish": "node ../../scripts/prepublish.js" | ||
|
There was a problem hiding this comment. @ndelangen you should perhaps check this change. There was a problem hiding this comment. I added this to shorten the paths, if this is removed the manual needs to be updated There was a problem hiding this comment. I updated the README for the package, was there anything else that needed to change? |
||
| }, | ||
| "devDependencies": { | ||
| "shelljs": "^0.7.7" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| /* eslint import/prefer-default-export: "off" */ | ||
|
|
||
| export { | ||
| default as updateOrganisationName, | ||
| packageNames, | ||
| } from './transforms/update-organisation-name'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a reliable way to get the path to the compiled package?
jscodeshiftdoesn't appear to offer its commandline functionality via an APIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you found this method to be unreliable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it feels a little hacky. For instance it hard codes the path of the binary into this file (rather than
npm run jscodeshiftwhich uses thebinfield ofjscodeshift'spackage.json).