Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix subcomponents display logic #11415

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Addon-docs: Fix subcomponents display logic #11415

merged 2 commits into from
Jul 4, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 4, 2020 •
edited
Loading

Issue: #10958

What I did

This change simplifies the Props display logic. Now:

  • Story table are always shown on the first tab
  • The component's component is shown if:
    • There is no story table
    • The user forces it with the showComponent prop
  • Subcomponents tables (if provided) are always shown on more tabs

How to test

See props.stories.mdx in official-storybook

@shilman shilman added this to the 6.0 args milestone Jul 4, 2020
@shilman shilman requested a review from usulpro as a code owner July 4, 2020 01:09
tmeasday
tmeasday requested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic is NQR

addons/docs/src/blocks/Props.tsx Outdated
if (!story || showComponent) {
allComponents = { [mainLabel]: main };
}
allComponents = { ...allComponents, ...subcomponents };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we just check that allComponents is falsy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated w/ slightly cleaner code. logic is same AFAIK because spreading falsey is allowed

@shilman shilman merged commit da10252 into next Jul 4, 2020
This was referenced Jul 4, 2020
Closed
Merged
This was referenced Dec 15, 2021
Closed
Closed
This was referenced Apr 7, 2022
Closed
Closed
Closed
@stof stof deleted the 10958-fix-argstable-subcomponnets branch May 25, 2022 09:27
@snyk-bot snyk-bot mentioned this pull request May 25, 2022
Open
This was referenced Jun 2, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2023
Open
@lili2311 lili2311 mentioned this pull request Jun 23, 2023
Open
@lili2311 lili2311 mentioned this pull request Aug 11, 2023
Open
This was referenced Sep 25, 2023
Open
Open
This was referenced Nov 25, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday requested changes

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: docs args block: props bug
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday