Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Consistent file paths for locally-defined addons #11368

Merged
merged 8 commits into from
Jul 6, 2020
Merged

Core: Consistent file paths for locally-defined addons #11368

merged 8 commits into from
Jul 6, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 1, 2020 •
edited
Loading

Issue: #9773

What I did

Minimal repro for #9773. I expect to be able to reference ./localAddon in main.ts. cc @ndelangen

How to test

cd examples/cra-ts-kitchen-sink
yarn storybook

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2020 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 357a45e

@shilman shilman changed the title Examples: Create repro for #9773 Examples: Create repro for inconsistent file paths in #9773 Jul 1, 2020
@shilman shilman changed the title Examples: Create repro for inconsistent file paths in #9773 Examples: Create repro for inconsistent main.js file paths Jul 1, 2020
@ndelangen ndelangen added this to the 6.0 milestone Jul 2, 2020
@shilman shilman modified the milestones: 6.0, 6.0 breaking Jul 2, 2020
@ndelangen ndelangen mentioned this pull request Jul 3, 2020
Closed
@shilman shilman changed the title Examples: Create repro for inconsistent main.js file paths Core: Consistent file paths for locally-defined addons Jul 3, 2020
@shilman
Copy link
Member Author

shilman commented Jul 3, 2020

@ndelangen can you look at the failing unit tests?

@shilman shilman modified the milestones: 6.0 breaking, 6.0 rc Jul 6, 2020
@ndelangen
Copy link
Member

@shilman unit tests should pass now

@shilman shilman merged commit 4ea75cb into next Jul 6, 2020
@shilman shilman deleted the 9773-inconsistent-paths branch July 6, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
BREAKING CHANGE configuration
Projects
None yet
Milestone
6.0 rc
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @ndelangen