E2E: remove cli fixtures in favor of e2e #11357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndelangen if this is all green, should we proceed like this and forgot failing tests from the other PR ? |
ndelangen
approved these changes
Jun 30, 2020
gaetanmaisse
approved these changes
Jun 30, 2020
| export const angularv7: Parameters = { | ||
| ...baseAngular, | ||
| version: 'v7-lts', | ||
| additionalDeps: [...baseAngular.additionalDeps, 'core-js'], |
There was a problem hiding this comment.
I'm wondering why core-js is needed, can you give me some hints?
There was a problem hiding this comment.
It's not "needed", but v7 (didn't checked above) installs core-js v2 which cause some issues with storybook
These names are used to init NPM project and so must follow validation rules: https://github.com/npm/validate-npm-package-name Moreover, they are now all consistant.
|
Just added 2 commits to fix Yarn 2 tests run, it was failing because we were trying to init project with a name invalid for NPM. Everything should be 🟢 . Good job @tooppaaa 💪 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.