Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview-body: Fix misleading docs #11337

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Preview-body: Fix misleading docs #11337

merged 2 commits into from
Jun 29, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 27, 2020

Issue: #11296

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 27, 2020
@shilman shilman requested a review from ndelangen as a code owner June 27, 2020 13:20
@schicks
Copy link

schicks commented Jun 27, 2020

This definitely makes it clearer; would it be possible to also also add a note that the root of the story will always be in a particular place?

@shilman
Copy link
Member Author

shilman commented Jun 27, 2020

@schicks thanks, added!

@shilman shilman merged commit 0299320 into next Jun 29, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 7, 2020
shilman added a commit that referenced this pull request Jul 7, 2020
@stof stof deleted the fix/preview-body-docs branch May 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants