Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-docs): markdown tables right align support #11280

Merged
merged 1 commit into from
Jun 24, 2020
Merged

fix(addon-docs): markdown tables right align support #11280

merged 1 commit into from
Jun 24, 2020

Conversation

frassinier
Copy link
Contributor

Closes #10666

What I did

I removed hardcoded text alignment on tables.
So if they are defined to be right-aligned, let's the tables be left-aligned when we use Markdown. 🤷‍♂️

How to test

  • Is this testable with Jest or Chromatic screenshots? Of course 🙏
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@frassinier frassinier requested a review from shilman June 23, 2020 19:56
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against f4a429a

@ndelangen ndelangen merged commit 89ccec5 into next Jun 24, 2020
@ndelangen ndelangen deleted the fix/addon-docs/markdown_tables_right_align_support branch June 24, 2020 09:12
@shilman shilman mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
addon: docs bug theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addon-docs: Markdown tables do not support column alignment
3 participants
@frassinier @ndelangen @shilman