Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgsTable: Updated Boolean control #11263

Merged
merged 10 commits into from
Jun 23, 2020
Merged

ArgsTable: Updated Boolean control #11263

merged 10 commits into from
Jun 23, 2020

Conversation

domyen
Copy link
Member

@domyen domyen commented Jun 22, 2020 •
edited
Loading

Issue: #11211

What I did

  • Updated boolean
  • Updated Control addon panel warning message

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes. Go to UI Review PR check to see what changed.

@shilman Can you do me a favor and document ControlsPanel:default and ControlsPanel: not configured? I styled them just now but I'm afraid we're going to have UI regressions if we don't have stories. Especially since the ControlsPanel layout is different from the ArgsTable in SB Docs.

default not configured
image image

@domyen domyen added ui cleanup Minor cleanup style change that won't show up in release changelog labels Jun 22, 2020
@shilman shilman added maintenance User-facing maintenance tasks and removed cleanup Minor cleanup style change that won't show up in release changelog labels Jun 23, 2020
@shilman shilman changed the title Argstable design tweaks ArgsTable: Updated boolean control and cleanup Jun 23, 2020
@shilman shilman changed the title ArgsTable: Updated boolean control and cleanup ArgsTable: New Boolean control Jun 23, 2020
@shilman shilman added this to the 6.0 args milestone Jun 23, 2020
shilman
shilman approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @domyen. Merging!

@shilman shilman changed the title ArgsTable: New Boolean control ArgsTable: Updated Boolean control Jun 23, 2020
@shilman shilman merged commit 9027827 into next Jun 23, 2020
@shilman shilman deleted the 11211-argstable-design-refresh branch June 23, 2020 07:05
@shilman shilman mentioned this pull request Jun 23, 2020
Closed
8 tasks
@lili2311 lili2311 mentioned this pull request Jun 21, 2023
Open
@lili2311 lili2311 mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@shilman shilman

Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.
2 participants
@domyen @shilman