Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Remove render for react components missing docgen #11195

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Jun 16, 2020

Issue: #11176

What I did

Remove render completely -- it's unclear whether it solves any problems and it causes them in some cases

@tooppaaa tooppaaa requested a review from shilman June 16, 2020 11:37
@tooppaaa tooppaaa self-assigned this Jun 16, 2020
@shilman shilman changed the title Addon-docs: Do not try to render react components for args Addon-docs: Remove render preprocessing for react components Jun 16, 2020
@shilman shilman changed the title Addon-docs: Remove render preprocessing for react components Addon-docs: Remove render preprocessing for react components w/o docgen Jun 16, 2020
@shilman shilman changed the title Addon-docs: Remove render preprocessing for react components w/o docgen Addon-docs: Remove render for react components missing docgen Jun 16, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tooppaaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants