React: Load root tsconfig.json into docgen-typescript if none provided #11184
Conversation
shilman
changed the title
There was a problem hiding this comment.
LGTM @hipstersmoothie ! Thanks for the quick fix!!!
@mrmckeb can you review? we probably need something similar for the CRA preset?
@ndelangen we add path.resolve in other parts of the code. do we need it here?
|
@hipstersmoothie unrelated to this PR. this snapshot is inconsistent and toggles back and forth between the two orders randomly: https://www.chromatic.com/snapshot?appId=5a375b97f4b14f0020b0cda3&id=5ee824c77183c0002207abf8 Is there a good fix in |
|
I’ll take a look tomorrow! |
| export function webpackFinal(config: Configuration, { typescriptOptions }: StorybookOptions) { | ||
| const { reactDocgen, reactDocgenTypescriptOptions } = typescriptOptions; | ||
| const { reactDocgen, reactDocgenTypescriptOptions = {} } = typescriptOptions; |
There was a problem hiding this comment.
This is already the default, it's set in defaults.js :)
https://github.com/storybookjs/storybook/blob/next/lib/core/src/server/config/defaults.js
We added it very recently. However, if it's not working for you - let me know, as that would be a bug.
| !reactDocgenTypescriptOptions.compilerOptions && | ||
| fs.existsSync(tsconfigPath) | ||
| ) { | ||
| reactDocgenTypescriptOptions.tsconfigPath = tsconfigPath; |
There was a problem hiding this comment.
Could this be something that's done internally, inside the plugin? As a user, I prefer tools to default to the standard location/name for a tsconfig.json if I don't provide one.
| @@ -47,7 +47,7 @@ | |||
| "enzyme-adapter-react-16": "^1.9.1", | |||
| "enzyme-to-json": "^3.4.1", | |||
| "fork-ts-checker-webpack-plugin": "^4.0.3", | |||
| "react-docgen-typescript-plugin": "^0.4.0", | |||
There was a problem hiding this comment.
Do we need this dep at all? i made RDTP a hard dep in the CRA preset because it was breaking with SB 5.3 instances.
There was a problem hiding this comment.
And it's already a dep in @storybook/react
Issue: #11146
What I did
Use root
tsconfig.jsonfor react-docgen-typescript if no tsconfig options are providedHow to test
Tested in bug reproduction repo