Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose addon title as a function in the interface + add number of knobs #11075

Merged
merged 8 commits into from
Jun 8, 2020

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jun 7, 2020

Issue: technically solves #11005

What I did

  • exposed title as a function in addon typings (tabs support this in their implementation)
  • added count of knobs in the knobs title (knobs will be deprecated but still nice to support this as it was asked)
  • added number of the controls in the controls title

like this
image

@igor-dv igor-dv added the ready label Jun 8, 2020
@igor-dv igor-dv merged commit 3cd5125 into next Jun 8, 2020
@igor-dv igor-dv deleted the 11005-addons-title-as-function branch June 8, 2020 10:00
@ndelangen
Copy link
Member

he's back! 😎

@yairEO
Copy link
Contributor

yairEO commented Jun 11, 2020

@igor-dv - Thank you!!!

Where can I read about knobs being deprecated? I would like to know why and what will replace them and also what will be regarding compatibility with already-written tons of knobs in many stories..

Also, would it be easier to also add a number for the "actions" tab (next to the knobs)?
it would help a lot to know if any action was fired without clicking that tab on every story to check if someone had implemented any actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants