Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix options control types #11003

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 1, 2020

Issue: #10947

What I did

Add documentation per #10947 request, FLATTEN the options control specification. This was actually a bug--something I'd started earlier but didn't finish.

Before:

  argTypes: {
    loadingState: {
      type: 'options',
      controlType: 'inline-radio',
      options: ['loading', 'error', 'ready'],
    },
  },

After:

  argTypes: {
    loadingState: {
      type: 'inline-radio',
      options: ['loading', 'error', 'ready'],
    },
  },

How to test

See stories: https://github.com/storybookjs/storybook/blob/next/lib/components/src/controls/options/Options.stories.tsx

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2020

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against d867278

@shilman shilman changed the title Controls: Flatten options control specification Controls: Flatten options control type Jun 1, 2020
@shilman shilman changed the title Controls: Flatten options control type Controls: Fix options control types Jun 1, 2020
@shilman
Copy link
Member Author

shilman commented Jun 1, 2020

Self-merging @tmeasday

@shilman shilman merged commit a3a6fa3 into next Jun 1, 2020
matheo added a commit to matheo/storybook that referenced this pull request Jun 2, 2020
@stof stof deleted the 10947-controls-options-customization branch May 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant