Added snapshotWithOptions to configure storyshots rendering options
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See for instance #896 -- it's a common problem to need mocked nodes. This solution is probably a bit of a bandaid, as large projects would probably want to set options per-story, this is a lot better than nothing in the meantime.
tmeasday
changed the title
snapshotWithOptions test body and examplesnapshotWithOptions to allow configuring rendering options in Storyshots
tmeasday
changed the title
snapshotWithOptions to allow configuring rendering options in StoryshotssnapshotWithOptions to allow configuring rendering options in Storyshots
Closed
ndelangen
approved these changes
May 22, 2017
shilman
changed the title
snapshotWithOptions to allow configuring rendering options in StoryshotssnapshotWithOptions to configure Storyshots rendering options
shilman
changed the title
snapshotWithOptions to configure Storyshots rendering optionssnapshotWithOptions to configure storyshots rendering options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
See for instance #896 -- it's a common problem to need mocked nodes.
This solution is probably a bit of a bandaid, as large projects would probably want to set options per-story, this is a lot better than nothing in the meantime.
Fixes #1085, and to some degree #881 and #876
What I did
Added a
snapshotWithOptionstest body, and an example of usage in thetest-craapp.How to test
Run
npm test. Try removing thetestoption and it should fail with anundefinedaccess issue.